linux-kernel - Re: [PATCH] Prevent the loop in timespec_add

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0802282257490.3111@apollo.tec.linutronix.de>
Date:	Thu, 28 Feb 2008 22:58:49 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Andrew Morton <akpm@...ux-foundation.org>
cc:	Segher Boessenkool <segher@...nel.crashing.org>,
	linux-kernel@...r.kernel.org, Ingo Molnar <mingo@...e.hu>,
	john stultz <johnstul@...ibm.com>
Subject: Re: [PATCH] Prevent the loop in timespec_add_ns() to be optimised
 away

On Wed, 27 Feb 2008, Andrew Morton wrote:

> On Fri, 22 Feb 2008 22:40:45 +0100
> Segher Boessenkool <segher@...nel.crashing.org> wrote:
> 
> > ...since some architectures don't support __udivdi3() (and
> > we don't want to use that, anyway).
> > 
> > Signed-off-by: Segher Boessenkool <segher@...nel.crashing.org>
> > ---
> >  include/linux/time.h |    4 ++++
> >  1 files changed, 4 insertions(+), 0 deletions(-)
> > 
> > diff --git a/include/linux/time.h b/include/linux/time.h
> > index 2091a19..d32ef0a 100644
> > --- a/include/linux/time.h
> > +++ b/include/linux/time.h
> > @@ -174,6 +174,10 @@ static inline void timespec_add_ns(struct timespec *a, u64 ns)
> >  {
> >  	ns += a->tv_nsec;
> >  	while(unlikely(ns >= NSEC_PER_SEC)) {
> > +		/* The following asm() prevents the compiler from
> > +		 * optimising this loop into a modulo operation.  */
> > +		asm("" : "+r"(ns));
> > +
> >  		ns -= NSEC_PER_SEC;
> >  		a->tv_sec++;
> >  	}
> 
> It's pretty sad that we need to turn this into a loop just because of the
> __udivdi3() thing.
> 
> otoh, it's rarely occurring, and it could be that the number of times it
> loops is usually 1 (if it wasn't zero), so perhaps a loop is faster than a
> divide anyway.
> 
> This code is probably too large to be inlined.
> 
> I queued this patch as needed-in-2.6.25, to-be-merged-via-Thomas.

Are you going to send it or should I grab it from the mailing list
myself ?

Thanks,
	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/