linux-kernel - Re: [PATCH 3/3] Consolidate send_sigqueue and send_group

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0802280546360.7583@apollo.tec.linutronix.de>
Date:	Thu, 28 Feb 2008 05:54:51 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	Oleg Nesterov <oleg@...sign.ru>
cc:	Pavel Emelyanov <xemul@...nvz.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Roland McGrath <roland@...hat.com>
Subject: Re: [PATCH 3/3] Consolidate send_sigqueue and send_group_sigqueue

On Fri, 22 Feb 2008, Oleg Nesterov wrote:
> > -
> > -	if (unlikely(!list_empty(&q->list))) {
> > -		/*
> > -		 * If an SI_TIMER entry is already queue just increment
> > -		 * the overrun count.
> > -		 */
> > -		BUG_ON(q->info.si_code != SI_TIMER);
> > -		q->info.si_overrun++;
> > -		goto out;
> > -	}
> > -	/* Short-circuit ignored signals.  */
> > -	if (sig_ignored(p, sig)) {
> > -		ret = 1;
> > -		goto out;
> > -	}

> >  send_group_sigqueue(int sig, struct sigqueue *q, struct task_struct *p)

> > -	/* Short-circuit ignored signals.  */
> > -	if (sig_ignored(p, sig)) {
> > -		ret = 1;
> > -		goto out;
> > -	}
> > -
> > -	if (unlikely(!list_empty(&q->list))) {
> > -		/*
> > -		 * If an SI_TIMER entry is already queue just increment
> > -		 * the overrun count.  Other uses should not try to
> > -		 * send the signal multiple times.
> > -		 */
> > -		BUG_ON(q->info.si_code != SI_TIMER);
> > -		q->info.si_overrun++;
> > -		goto out;
> > -	} 
> 
> Personally, I think this change is very good. But send_sigqueue() and
> send_group_sigqueue() have a very subtle difference which I was never
> able to understand.
> 
> Let's suppose that sigqueue is already queued, and the signal is ignored
> (the latter means we should re-schedule cpu timer or handle overrruns).
> In that case send_sigqueue() returns 0, but send_group_sigqueue() returns 1.
> 
> I think this is not the problem (in fact, I think this patch makes the
> behaviour more correct), but I hope Thomas can take a look and confirm.

It should not change anything. We should never have a signal enqueued
when it's ignored anyway.

Roland, any insight why this is different aside of a copy and paste
error ?

Thanks,

	tglx
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/