linux-kernel - Re: [patch 1/2] add ALL_CPUS option to stop_machine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080229090050.GA19519@elte.hu>
Date:	Fri, 29 Feb 2008 10:00:50 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Max Krasnyanskiy <maxk@...lcomm.com>
Cc:	Jason Baron <jbaron@...hat.com>,
	Mathieu Desnoyers <mathieu.desnoyers@...ymtl.ca>,
	akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
	Rusty Russell <rusty@...tcorp.com.au>,
	Peter Zijlstra <a.p.zijlstra@...llo.nl>
Subject: Re: [patch 1/2] add ALL_CPUS option to stop_machine_run()


* Max Krasnyanskiy <maxk@...lcomm.com> wrote:

>> -allow stop_mahcine_run() to call a function on all cpus. Calling 
>> stop_machine_run() with a 'ALL_CPUS' invokes this new behavior.
>>  stop_machine_run() proceeds as normal until the calling cpu has 
>>  invoked 'fn'. Then, we tell all the other cpus to call 'fn'.
>
> Jason, we're actually trying to reduce the usage of the stop_machine 
> in general. [...]

please talk in your own name. Stop-machine is a very elegant tool that 
simplifies a lot of hard things in the kernel and is reasonably fast as 
well. We've just recently added two new usages of it and more are 
planned.

_you_ might be the one who wants to 'reduce the usage of stop_machine' - 
but that means it is _you_ who first has to convert a number of very 
difficult pieces of code to "something else".

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/