linux-kernel - Re: trivial clean up to zlc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200802291531.36498.caglar@pardus.org.tr>
Date:	Fri, 29 Feb 2008 15:31:34 +0200
From:	"S.Çağlar Onur" <caglar@...dus.org.tr>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Lee Schermerhorn <Lee.Schermerhorn@...com>,
	Paul Jackson <pj@....com>, linux-mm@...ck.org,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: trivial clean up to zlc_setup

Hi;

29 Şub 2008 Cum tarihinde, KOSAKI Motohiro şunları yazmıştı: 
> > > -       if (jiffies - zlc->last_full_zap > 1 * HZ) {
> > > +       if (time_after(jiffies, zlc->last_full_zap + HZ)) {
> > >                 bitmap_zero(zlc->fullzones, MAX_ZONES_PER_ZONELIST);
> > >                 zlc->last_full_zap = jiffies;
> > >         }
> > 
> > That's a mainline bug.  Also present in 2.6.24, maybe earlier.
> > But it's a minor one - we'll fix it up one second later (yes?)
> 
> I think so, may be.

Andrew "Use time_* macros" series i sent to LKML on 14 Feb [1] has this chunk also (and by the way this version not includes linux/jiffies.h for time_after macro). Some part of this series already gone into Linus's tree with different subsystems but others not received any review/ack or nack. Will you grab others for -mm or will i resend them?

[1] http://lkml.org/lkml/2008/2/14/195

Cheers
-- 
S.Çağlar Onur <caglar@...dus.org.tr>
http://cekirdek.pardus.org.tr/~caglar/

Linux is like living in a teepee. No Windows, no Gates and an Apache in house!

Download attachment "signature.asc " of type "application/pgp-signature" (190 bytes)