linux-kernel - Re: [patch 2/3] Trace code and documentation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <47C832AC.4040906@us.ibm.com>
Date:	Fri, 29 Feb 2008 08:28:28 -0800
From:	David Wilder <dwilder@...ibm.com>
To:	Andrew Morton <akpm@...ux-foundation.org>
CC:	linux-kernel@...r.kernel.org, systemtap@...rceware.org,
	prasadav@...ibm.com, hch@...radead.org
Subject: Re: [patch 2/3]  Trace code and documentation

Andrew Morton wrote:
> On Tue, 26 Feb 2008 14:38:48 -0800 "David J. Wilder" <dwilder@...ibm.com> wrote:
> 
>> +	if (strncmp(buf, "start", strlen("start")) == 0) {
>> +		ret = trace_start(trace);
>> +		if (ret)
>> +			return ret;
>> +	} else if (strncmp(buf, "stop", strlen("stop")) == 0)
>> +		trace_stop(trace);
> 
> Does gcc manage to avoid the pointless strlen() calls here?
> 
> It's a bit untidy that you can write "startfoo" in there and the kernel
> will happily accept it.

I agree.  I will change it to something like this in my next update.


buf[count-1] = '\0';

if (strcmp(buf, "start") == 0) {
	ret = trace_start(trace);
	if (ret)
		return ret;
} else if (strcmp(buf, "stop") == 0)
	trace_stop(trace);
else
	return -EINVAL;



--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/