linux-kernel - Re: [PATCH] iwch_create

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <47C83798.3090702@opengridcomputing.com>
Date:	Fri, 29 Feb 2008 10:49:28 -0600
From:	Steve Wise <swise@...ngridcomputing.com>
To:	Roland Dreier <rdreier@...co.com>
CC:	Jon Mason <jon@...ngridcomputing.com>,
	linux-kernel@...r.kernel.org, general@...ts.openfabrics.org
Subject: Re: [PATCH] iwch_create_cq off by one error

Acked-by: Steve Wise <swise@...ngridcomputing.com>


Jon Mason wrote:
> The cxbg3 driver is unnecessarily decreasing the number of cq entries
> by one when creating a cq.  This will cause an error of not having as
> many cqs as requested by the user, if the user requests a power of 2
> cq length.
> 
> Thanks,
> Jon
> 
> Signed-off-by: Jon Mason <jon@...ngridcomputing.com>
> ---
>  drivers/infiniband/hw/cxgb3/iwch_provider.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> diff --git a/drivers/infiniband/hw/cxgb3/iwch_provider.c b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> index f0c7775..800ef6d 100644
> --- a/drivers/infiniband/hw/cxgb3/iwch_provider.c
> +++ b/drivers/infiniband/hw/cxgb3/iwch_provider.c
> @@ -188,7 +188,7 @@ static struct ib_cq *iwch_create_cq(struct ib_device *ibdev, int entries, int ve
>  		return ERR_PTR(-ENOMEM);
>  	}
>  	chp->rhp = rhp;
> -	chp->ibcq.cqe = (1 << chp->cq.size_log2) - 1;
> +	chp->ibcq.cqe = 1 << chp->cq.size_log2;
>  	spin_lock_init(&chp->lock);
>  	atomic_set(&chp->refcnt, 1);
>  	init_waitqueue_head(&chp->wait);

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/