linux-kernel - Re: [PATCH] x86_64 ia32 syscall restart fix

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0802290855230.17889@woody.linux-foundation.org>
Date:	Fri, 29 Feb 2008 09:03:04 -0800 (PST)
From:	Linus Torvalds <torvalds@...ux-foundation.org>
To:	Ingo Molnar <mingo@...e.hu>
cc:	Roland McGrath <roland@...hat.com>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Thomas Gleixner <tglx@...utronix.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] x86_64 ia32 syscall restart fix

On Fri, 29 Feb 2008, Ingo Molnar wrote:
> 
> currently the reality is that i have to fix over 90% of the commit 
> messages that go towards you :-/

Heh, yeah. My percentage ends up being much lower, mostly because patches 
that come through Andrew are generally already cleaned-up (I edit those 
too, but it tends to be one or two per batch, not more than that).

I'm happy you do edit them, because not everybody does, and I do think 
it's part of being a subsystem maintainer, but I also end up occasionally 
sending emails to the parties involved to try to keep editing to a mimumum 
in the future - I personally suspect that it's to a large degree because 
people don't think about the effect in the logs..

(Some other projects also tend to have very different models for what a 
commit message should look like, so much of it is probably "cultural" too. 

I've seen projects that consistently had totally unreadable one-liner 
commit messages because (a) nobody ever read them anyway (because the log 
just isn't useful when it's per-file) and (b) people were encouraged to 
just use things like 'cvs ci -m"Fix bug"' to check in their stuff.

So the kernel is probably fairly odd in generally not asking for any 
fixed-format stuff at all (like the GNU changelogs do) but instead writing 
a small human-readable novella ;)

			Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/