linux-kernel - Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080229205400.GG27212@elte.hu>
Date:	Fri, 29 Feb 2008 21:54:00 +0100
From:	Ingo Molnar <mingo@...e.hu>
To:	Michael Buesch <mb@...sch.de>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	Alexey Zaytsev <alexey.zaytsev@...il.com>,
	Larry Finger <Larry.Finger@...inger.net>,
	Stefano Brivio <stefano.brivio@...imi.it>,
	Jeff Garzik <jgarzik@...ox.com>, Greg KH <greg@...ah.com>,
	Pekka Enberg <penberg@...helsinki.fi>,
	linux-kernel@...r.kernel.org, linux-wireless@...r.kernel.org
Subject: Re: [PATCH] Fix the bcm43xx driver breakage in 2.6.24/25.


* Michael Buesch <mb@...sch.de> wrote:

> On Friday 29 February 2008 09:21:19 Andrew Morton wrote:
> > On Sat, 23 Feb 2008 16:17:55 +0300 Alexey Zaytsev <alexey.zaytsev@...il.com> wrote:
> > 
> > > Theese two patches fix a problem instroduced in Linux 2.6.24, and
> > > still present in the current Linus' 2.6.25 tree.
> > > 
> > > The bcm43xx Wifi driver won't work any more, if the b44 Ethernet
> > > driver is enabled. This happens because the b44 driver
> > > needlessly enables the b43_pci_bridge code, which claims
> > > the same pci ids as the bcm43xx driver. The b43_pci_bridge
> > > code is needed for the b43{legacy} drivers, but for the
> > > b44, only the "ssb pci core" is needed.
> > 
> > Hate to stick my head into this beehive, but...
> > 
> > I have a patch queued (the-scheduled-bcm43xx-removal.patch) which 
> > will remove this driver from 2.6.26.
> > 
> > Is that bad?
> 
> Not at all. The b43 driver from 2.6.26 will work. So there's no reason 
> to keep bcm43xx. Alexey just tested a patch that backports the fix to 
> 2.6.24 and it works fine.

yeah, i'd support the removal of it too, if the transition is smooth and 
the regressions are resolved. And it should be smooth, as long as users 
are able to load the firmware blob, right? There's also an entry for it 
in Documentation/feature-removal-schedule.txt:

  What:   bcm43xx wireless network driver
  When:   2.6.26
  Files:  drivers/net/wireless/bcm43xx
  Why:    This driver's functionality has been replaced by the
          mac80211-based b43 and b43legacy drivers.
  Who:    John W. Linville <linville@...driver.com>

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/