linux-kernel - Re: [patch 09/21] (NEW) improve reclaim balancing

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080301221216.529E.KOSAKI.MOTOHIRO@jp.fujitsu.com>
Date:	Sat, 01 Mar 2008 22:35:44 +0900
From:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To:	Rik van Riel <riel@...hat.com>
Cc:	kosaki.motohiro@...fujitsu.com, linux-kernel@...r.kernel.org,
	Lee Schermerhorn <Lee.Schermerhorn@...com>, linux-mm@...ck.org
Subject: Re: [patch 09/21] (NEW) improve reclaim balancing

hi

> +	/*
> +	 * Even if we did not try to evict anon pages at all, we want to
> +	 * rebalance the anon lru active/inactive ratio.
> +	 */
> +	if (inactive_anon_low(zone))
> +		shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
> +								priority);
> +

you want check global zone status, right?
if so, this statement only do that at global scan.


- kosaki

---
 mm/vmscan.c |    4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Index: b/mm/vmscan.c
===================================================================
--- a/mm/vmscan.c       2008-03-01 22:18:42.000000000 +0900
+++ b/mm/vmscan.c       2008-03-01 22:42:42.000000000 +0900
@@ -1319,9 +1319,9 @@ static unsigned long shrink_zone(int pri
         * Even if we did not try to evict anon pages at all, we want to
         * rebalance the anon lru active/inactive ratio.
         */
-       if (inactive_anon_low(zone))
+       if (scan_global_lru(sc) && inactive_anon_low(zone))
                shrink_list(NR_ACTIVE_ANON, SWAP_CLUSTER_MAX, zone, sc,
                                                               priority);

        throttle_vm_writeout(sc->gfp_mask);
        return nr_reclaimed;


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/