linux-kernel - Re: [2.6 patch] acpi/battery.c: make 2 functions static

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sat, 1 Mar 2008 20:45:15 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Alexey Starikovskiy <aystarik@...il.com>
Cc:	lenb@...nel.org, astarikovskiy@...e.de, linux-acpi@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] acpi/battery.c: make 2 functions static

On Sat, Mar 01, 2008 at 09:42:59PM +0300, Alexey Starikovskiy wrote:
> Adrian Bunk wrote:
>> On Sat, Mar 01, 2008 at 09:26:41PM +0300, Alexey Starikovskiy wrote:
>>   
>>> May I keep them inline?
>>>     
>>
>> The problem with such manual inlines is that we force gcc to always  
>> inline them - and history has shown that functions grow without the  
>> "inline" being removed.
>>
>>   And for static functions gcc should (at least in theory) know best 
>> when to inline them.
>>
>>   
> Right. Acked-by: Alexey Starikovskiy <astarikovskiy@...e.de>
>
> As I understand, you have some automation tools for finding out these
> non-static functions, etc; are they available somewhere?

Type "make namespacecheck" after compiling the kernel.  

> Regards,
> Alex.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/