linux-kernel - m32r and ISA

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080301190110.GE25835@cs181133002.pp.htv.fi>
Date:	Sat, 1 Mar 2008 21:01:10 +0200
From:	Adrian Bunk <bunk@...nel.org>
To:	Jean Delvare <khali@...ux-fr.org>, takata@...ux-m32r.org
Cc:	i2c@...sensors.org, linux-kernel@...r.kernel.org,
	linux-m32r@...linux-m32r.org
Subject: m32r and ISA

On Thu, Feb 28, 2008 at 06:49:12PM +0100, Jean Delvare wrote:
> Hi Adrian,
> 
> On Wed, 27 Feb 2008 09:37:28 +0200, Adrian Bunk wrote:
> > This patch fixes the following compile error on m32r:
> > 
> > <--  snip  -->
> > 
> > ...
> >   CC [M]  drivers/i2c/busses/i2c-elektor.o
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_setbyte':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:80: error: implicit declaration of function 'iowrite8'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_getbyte':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:90: error: implicit declaration of function 'ioread8'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'pcf_isa_init':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:153: error: implicit declaration of function 'ioport_map'
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:153: warning: assignment makes pointer from integer without a cast
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c: In function 'elektor_probe':
> > /home/bunk/linux/kernel-2.6/git/linux-2.6/drivers/i2c/busses/i2c-elektor.c:290: error: implicit declaration of function 'ioport_unmap'
> > make[4]: *** [drivers/i2c/busses/i2c-elektor.o] Error 1
> > 
> > <--  snip  -->
> > 
> > Signed-off-by: Adrian Bunk <adrian.bunk@...ial.fi>
> > 
> > ---
> > c8a75f0dd2390ae8c8f91c451ff6b0e113d0ebd0 diff --git a/drivers/i2c/busses/Kconfig b/drivers/i2c/busses/Kconfig
> > index 476b0bb..3bed6b9 100644
> > --- a/drivers/i2c/busses/Kconfig
> > +++ b/drivers/i2c/busses/Kconfig
> > @@ -129,7 +129,7 @@ config I2C_DAVINCI
> >  
> >  config I2C_ELEKTOR
> >  	tristate "Elektor ISA card"
> > -	depends on ISA && BROKEN_ON_SMP
> > +	depends on ISA && HAS_IOPORT && BROKEN_ON_SMP
> >  	select I2C_ALGOPCF
> >  	help
> >  	  This supports the PCF8584 ISA bus I2C adapter.  Say Y if you own
> > 
> 
> Looks weird to me. As you can see, I2C_ELEKTOR already depends on ISA
> and I thought it would be sufficient. Your m32r system has
> CONFIG_HAS_IOPORT=n but CONFIG_ISA=y? I fail to see how a system could
> have ISA slots but not have IO ports.

I don't have any m32r system.

I'm just doing the sisyphus task of getting as many defconfigs as 
possible compiling.

I've added the m32r maintainer as recipient for this email since he 
might be the best person to answer your question.

> Jean Delvare

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/