linux-kernel - regression: ntfs build failure in linux-2.6.git on no-mmu: no is_vmalloc

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200803011508.45913.vapier.adi@gmail.com>
Date:	Sat, 1 Mar 2008 15:08:45 -0500
From:	Mike Frysinger <vapier.adi@...il.com>
To:	linux-kernel@...r.kernel.org, Andrew Morton <akpm@...l.org>
Cc:	uclinux-dist-devel@...ckfin.uclinux.org, cooloney@...nel.org
Subject: regression: ntfs build failure in linux-2.6.git on no-mmu: no is_vmalloc_addr()

On Saturday 01 March 2008 06:29:59 vapier@...ckfin.uclinux.org wrote:
> --- blackfin-2.6/BF548-EZKIT.BF542
> --- blackfin-2.6/BF548-EZKIT.BF544
> --- blackfin-2.6/BF548-EZKIT.BF547
> --- blackfin-2.6/BF548-EZKIT.BF548
> --- blackfin-2.6/BF548-EZKIT.BF549
> --- linux-2.6/BF548-EZKIT.BF542
> --- linux-2.6/BF548-EZKIT.BF544
> --- linux-2.6/BF548-EZKIT.BF547
> --- linux-2.6/BF548-EZKIT.BF548
> --- linux-2.6/BF548-EZKIT.BF549
> --- next-20080229/BF548-EZKIT.BF542
> --- next-20080229/BF548-EZKIT.BF544
> --- next-20080229/BF548-EZKIT.BF547
> --- next-20080229/BF548-EZKIT.BF548
> --- next-20080229/BF548-EZKIT.BF549
> <stdin>:1377:2: warning: #warning syscall timerfd_create not implemented
> <stdin>:1389:2: warning: #warning syscall timerfd_settime not implemented
> <stdin>:1393:2: warning: #warning syscall timerfd_gettime not implemented
> In file included from fs/ntfs/attrib.c:32:
> fs/ntfs/malloc.h: In function 'ntfs_free':
> fs/ntfs/malloc.h:88: error: implicit declaration of function
> 'is_vmalloc_addr' make[2]: *** [fs/ntfs/attrib.o] Error 1
> make[1]: *** [fs/ntfs] Error 2
> make: *** [fs] Error 2

commit 9e2779fa281cfda13ac060753d674bbcaa23367e changed fs/ntfs/malloc.h from
using VMALLOC_* defines to is_vmalloc_addr() (which makes sense), but Blackfin
was defining VMALLOC_* (to basically the range of all memory addresses like
most no-mmu ports)

so we can drop CONFIG_MMU around is_vmalloc_addr() in include/linux/mm.h, or
we can just make it return 1 all the time for no-mmu.  the former sounds
easier.

Signed-off-by: Mike Frysinger <vapier@...too.org>
---
diff --git a/include/linux/mm.h b/include/linux/mm.h
index 3f3ccfe..3b3e134 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -235,7 +235,6 @@ static inline int get_page_unless_zero(struct page *page)
 struct page *vmalloc_to_page(const void *addr);
 unsigned long vmalloc_to_pfn(const void *addr);
 
-#ifdef CONFIG_MMU
 /* Determine if an address is within the vmalloc range */
 static inline int is_vmalloc_addr(const void *x)
 {
@@ -243,7 +242,6 @@ static inline int is_vmalloc_addr(const void *x)
 
 	return addr >= VMALLOC_START && addr < VMALLOC_END;
 }
-#endif
 
 static inline struct page *compound_head(struct page *page)
 {
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/