linux-kernel - Re: WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <3d8471ca0803020515m1e4af9d9xd37a8912e58a4504@mail.gmail.com>
Date:	Sun, 2 Mar 2008 14:15:01 +0100
From:	"Guillaume Chazarain" <guichaz@...il.com>
To:	"Ilpo Järvinen" <ilpo.jarvinen@...sinki.fi>
Cc:	"Giangiacomo Mariotti" <giangiacomo_mariotti@...oo.com>,
	LKML <linux-kernel@...r.kernel.org>,
	Netdev <netdev@...r.kernel.org>,
	"Andrew Morton" <akpm@...ux-foundation.org>
Subject: Re: WARNING: at net/ipv4/tcp_input.c:2054 tcp_mark_head_lost()

On Sun, Mar 2, 2008 at 1:38 PM, Ilpo Järvinen <ilpo.jarvinen@...sinki.fi> wrote:
>  In future, please inline at least the first one of them, if not sure
>  where to cut, too much won't hurt... :-)

OK, will do.

>  > It does not contain any "KERNEL: assertion (packets <=
>  > tp->packets_out) failed at" line, so I'm afraid it's just noise.
>
>  At least it catches one bug which could cause that assertion (it is much
>  more rigid than the assertion and thus it catched it even though you
>  won't see that assertion to ever trigger :-)).

Great :-)

>  Could you next figure out what is at:
>   [<c02e0f83>] tcp_ack+0x621/0xd2f

tcp_clean_rtx_queue() is automatically inlined into tcp_ack() by gcc.

That's:

tcp_ack():
        /* See if we can take anything off of the retransmit queue. */
        flag |= tcp_clean_rtx_queue(sk, prior_fackets);

tcp_clean_rtx_queue():
        tcp_verify_left_out(tp);    <=========== Here

        if (skb && (TCP_SKB_CB(skb)->sacked & TCPCB_SACKED_ACKED))
                flag |= FLAG_SACK_RENEGING;


Thanks.

-- 
Guillaume