linux-kernel - [PATCH 0/2] IB/iSER bugfixes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Date:	Mon, 03 Mar 2008 11:35:48 +0100
From:	Arne Redlich <arne.redlich@...anet.com>
To:	Roland Dreier <rolandd@...co.com>
Cc:	ofa-general <general@...ts.openfabrics.org>,
	lkml <linux-kernel@...r.kernel.org>, erezz@...taire.com
Subject: [PATCH 0/2] IB/iSER bugfixes

Hi,

While reading through the iSER code I noticed two rather nasty issues:

1. The iteration through the list of "iser_device"s during device
lookup/creation is broken - it might result in an infinite loop if more
than 1 HCA is used with iSER. Use list_for_each_entry() instead of the
custom, flawed list iteration code.

2. "iser_device" allocation failure is "handled" with a BUG_ON() right
before dereferencing the NULL-pointer.
This is really scary, so here's my idea of a fix. Someone with a deeper
understanding of the code should have a look at it since I'm not sure it
does The Right Thing.

Both patches are merely compile tested, and patch #2 needs to be applied
on top of #1.

Cheers,
Arne
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/