linux-kernel - Re: [patch] hid: quirk to fixup fullspeed interval on highspeed devices

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Mon, 3 Mar 2008 13:50:14 +0100 (CET)
From:	Jiri Kosina <jkosina@...e.cz>
To:	Pekka Sarnila <sarnila@...t.fi>
cc:	linux-kernel@...r.kernel.org
Subject: Re: [patch] hid: quirk to fixup fullspeed interval on highspeed
 devices

On Sat, 1 Mar 2008, Pekka Sarnila wrote:

> Many vendors highspeed devices give erroneously fullspeed interval value 
> in endpoint descriptor for interrupt endpoints. This quirk fixes up that 
> by recalculating the right value for highspeed device.

Hi Pekka,

thanks for the patch. I however think that HID code is really a wrong 
place to to this, we really want to do this in USB core instead, as that 
it where it belongs.

Why do you think that adding a new quirk for this device to 
usb/core/quirks.c and then checking for it in usb_parse_endpoint() is not 
feasible?

Thanks,

-- 
Jiri Kosina
SUSE Labs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/