linux-kernel - Re: [PATCH RFC] introduce pm_call() macro to get rid of most #ifdef CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Sun, 2 Mar 2008 16:08:20 -0800
From:	Arjan van de Ven <arjan@...radead.org>
To:	Anton Vorontsov <cbouatmailru@...il.com>
Cc:	linux-kernel@...r.kernel.org, linux-pm@...ts.linux-foundation.org
Subject: Re: [PATCH RFC] introduce pm_call() macro to get rid of most #ifdef
 CONFIG_PM

On Mon, 3 Mar 2008 02:43:08 +0300
Anton Vorontsov <cbouatmailru@...il.com> wrote:

> Currently drivers handle CONFIG_PM this way:
> 
> #ifdef CONFIG_PM
> drv_suspend() {}
> drv_resume() {}
> #else
> #define drv_suspend NULL
> #define drv_resume NULL
> #endif
> 
> struct driver drv = {
> 	.suspend = drv_suspend,
> 	.resume = drv_resume,
> };
> 
> With this patch, the code above converts into:
> 
> drv_suspend() {}
> drv_resume() {}
> 
> struct driver drv = {
> 	.suspend = pm_call(drv_suspend),
> 	.resume = pm_call(drv_resume),
> };
> 
> GCC will optimize away suspend/resume calls if they're really
> not used.
> 


to be honest, at this point I would think it's time to remove CONFIG_PM, or rather,
just make it always be there and just get rid of the ifdefs. We're saving 2 words and a bit of code,
but only a case that not even the embedded guys use. 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/