[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 03 Mar 2008 12:21:27 +0900
From: KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
To: Rick van Rein <rick@...rein.org>
Cc: kosaki.motohiro@...fujitsu.com,
KOSAKI Motohiro <m-kosaki@...es.dti.ne.jp>, linux-mm@...ck.org,
linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2.6.24] mm: BadRAM support for broken memory
Hi Rick
> > > +#define PG_badram 20 /* BadRam page */
> >
> > some architecture use PG_reserved for treat bad memory.
> > Why do you want introduce new page flag?
>
> It is clearer to properly name a flag, I suppose.
> Is the use that you are mentioning the intended, and only use of the flag?
> If not, I think it is clearer to use a separate flag instead of overloading
> one.
hmmm
unfortunately flag bit of struct page is very valuable resource
rather than diamond on current implementaion ;-)
if you can change to no introduce new page flag,
IMHO merge to mainline dramatically become easy.
> > for show_mem() improvement?
>
> For code clarity.
agreed with your code is clarify. but...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists