[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date: Mon, 03 Mar 2008 13:54:00 -0500
From: Prarit Bhargava <prarit@...hat.com>
To: Jesse Barnes <jbarnes@...tuousgeek.org>
CC: Alex Chiang <achiang@...com>, Gary Hade <garyhade@...ibm.com>,
kaneshige.kenji@...fujitsu.com, warthog19@...lescrag.net,
Matthew Wilcox <matthew@....cx>, gregkh@...e.de,
kristen.c.accardi@...el.com, rick.jones2@...com,
linux-kernel@...r.kernel.org, linux-pci@...ey.karlin.mff.cuni.cz,
linux-acpi@...r.kernel.org
Subject: Re: [PATCH 1/4] Remove path attribute from sgi_hotplug
>> - bss_hotplug_slot->name = kmalloc(SN_SLOT_NAME_SIZE, GFP_KERNEL);
>> - if (!bss_hotplug_slot->name) {
>> - kfree(bss_hotplug_slot->private);
>> - return -ENOMEM;
>> - }
>> + bss_hotplug_slot->name = slot->physical_path;
>>
>> slot->device_num = device;
>> slot->pci_bus = pci_bus;
>> - sprintf(bss_hotplug_slot->name, "%04x:%02x:%02x",
>> - pci_domain_nr(pci_bus),
>> - ((u16)pcibus_info->pbi_buscommon.bs_persist_busnum),
>> - device + 1);
>>
>>
>
Ugh ... it has been a while since I've looked at or owned this code ;)
-- but I do seem to recall that on SGI boxes the slot's name was
different from the physical path of the device (ie, what was stamped on
the back of the PCI hotplug chassis was different from Linux' PCI name)
-- OTOH, I haven't recently looked at what slot->physical_path has been
initialized to, so they might now be one-and-the-same ....
P.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists