[<prev] [next>] [day] [month] [year] [list]
Date: Mon, 3 Mar 2008 23:46:51 +0100
From: "Rafael J. Wysocki" <rjw@...k.pl>
To: Greg KH <gregkh@...e.de>
Cc: Alan Stern <stern@...land.harvard.edu>,
Len Brown <lenb@...nel.org>,
LKML <linux-kernel@...r.kernel.org>, Pavel Machek <pavel@....cz>,
pm list <linux-pm@...ts.linux-foundation.org>
Subject: [PATCH] Device core: Remove dpm_sysfs_remove() from error path of device_add()
Hi Greg,
The appended patch fixes a bug in the error path of device_add().
Please accept it for 2.6.25.
Thanks,
Rafael
---
From: Rafael J. Wysocki <rjw@...k.pl>
Since device_pm_remove(dev) calls dpm_sysfs_remove(dev), it's
incorrect to call the latter after the former in the device_add()
error path.
Signed-off-by: Rafael J. Wysocki <rjw@...k.pl>
---
drivers/base/core.c | 1 -
1 file changed, 1 deletion(-)
Index: linux-2.6/drivers/base/core.c
===================================================================
--- linux-2.6.orig/drivers/base/core.c
+++ linux-2.6/drivers/base/core.c
@@ -839,7 +839,6 @@ int device_add(struct device *dev)
return error;
BusError:
device_pm_remove(dev);
- dpm_sysfs_remove(dev);
PMError:
if (dev->bus)
blocking_notifier_call_chain(&dev->bus->p->bus_notifier,
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists