linux-kernel - Re: [PATCH] lguest: make sure cpu is initialized before accessing it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <200803041119.44283.rusty@rustcorp.com.au>
Date:	Tue, 4 Mar 2008 11:19:44 +1100
From:	Rusty Russell <rusty@...tcorp.com.au>
To:	Eugene Teo <eugeneteo@...nel.sg>
Cc:	linux-kernel@...r.kernel.org, lguest@...abs.org
Subject: Re: [PATCH] lguest: make sure cpu is initialized before accessing it

On Tuesday 04 March 2008 10:15:47 Rusty Russell wrote:
> On Sunday 10 February 2008 02:53:17 Eugene Teo wrote:
> > If req is LHREQ_INITIALIZE, and the guest has been initialized before
> > (unlikely), it will attempt to access cpu->tsk even though cpu is not yet
> > initialized.
> >
> > Signed-off-by: Eugene Teo <eugeneteo@...nel.sg>

Thanks Eugene, I've applied this with some wrapping of the comments and 
removal of the now-redundant lg != NULL tests:

> > +		/* Once the Guest is dead, all you can do is read() why it died. */
> > +		if (lg && lg->dead)
> > +			return -ENOENT;
> >
> > -	/* If you're not the task which owns the Guest, you can only break */
> > -	if (lg && current != cpu->tsk && req != LHREQ_BREAK)
> > -		return -EPERM;
> > +		/* If you're not the task which owns the Guest, you can only break */
> > +		if (lg && current != cpu->tsk && req != LHREQ_BREAK)
> > +			return -EPERM;
> > +	}

Cheers,
Rusty.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/