linux-kernel - Re: [PATCH -mm 0/3] fix iommu segment boundary problems (parisc)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <JX7RR7$3528E2939A349F65E12E3F27315EEC50@scarlet.be>
Date:	Tue,  4 Mar 2008 17:13:55 +0100
From:	"rubisher" <rubisher@...rlet.be>
To:	"fujita\.tomonori" <fujita.tomonori@....ntt.co.jp>
Cc:	"tomof" <tomof@....org>, "kyle" <kyle@...artin.ca>,
	"linux-kernel" <linux-kernel@...r.kernel.org>,
	"linux-parisc" <linux-parisc@...r.kernel.org>,
	"tomof" <tomof@....org>, "kyle" <kyle@...isc-linux.org>,
	"matthew" <matthew@....cx>, "grundler" <grundler@...isc-linux.org>,
	"akpm" <akpm@...ux-foundation.org>,
	"fujita\.tomonori" <fujita.tomonori@....ntt.co.jp>,
	"rubisher" <rubisher@...rlet.be>
Subject: Re: [PATCH -mm 0/3] fix iommu segment boundary problems (parisc)

[snip]
> > Can you try the following patch? It's on the top of the patchset.
> > 
> Good catch: now this first testing system (I mean the b2k) is up and running ;-)
> 
> I will now try the ccio_dma driver on a d380 ...
> 
Yes, it works too on a d380 boxe running a 32bit up kernel.

Btw (it was a long time ago), I also resurrect my 64 config for the b2k model
and it also works fine.

Many tx again,
    r.

> hth,
>     r.
> 
> > Thanks,
> > 
> > diff --git a/drivers/parisc/ccio-dma.c b/drivers/parisc/ccio-dma.c
> > index 2f3b364..d0855a1 100644
> > --- a/drivers/parisc/ccio-dma.c
> > +++ b/drivers/parisc/ccio-dma.c
> > @@ -366,8 +366,8 @@ ccio_alloc_range(struct ioc *ioc, struct device *dev,
> size_t size)
> >  	** ggg sacrifices another 710 to the computer gods.
> >  	*/
> >  
> > -	boundary_size = ALIGN(dma_get_seg_boundary(dev) + 1, 1 << IOVP_SHIFT);
> > -	boundary_size >>= IOVP_SHIFT;
> > +	boundary_size = ALIGN((unsigned long long)dma_get_seg_boundary(dev) + 1,
> > +			      1ULL << IOVP_SHIFT) >> IOVP_SHIFT;
> >  
> >  	if (pages_needed <= 8) {
> >  		/*
> > diff --git a/drivers/parisc/sba_iommu.c b/drivers/parisc/sba_iommu.c
> > index e834127..bdbe780 100644
> > --- a/drivers/parisc/sba_iommu.c
> > +++ b/drivers/parisc/sba_iommu.c
> > @@ -341,8 +341,8 @@ sba_search_bitmap(struct ioc *ioc, struct device *dev,
> >  	unsigned long shift;
> >  	int ret;
> >  
> > -	boundary_size = ALIGN(dma_get_seg_boundary(dev) + 1, 1 << IOVP_SHIFT);
> > -	boundary_size >>= IOVP_SHIFT;
> > +	boundary_size = ALIGN((unsigned long long)dma_get_seg_boundary(dev) + 1,
> > +			      1ULL << IOVP_SHIFT) >> IOVP_SHIFT;
> >  
> >  #if defined(ZX1_SUPPORT)
> >  	BUG_ON(ioc->ibase & ~IOVP_MASK);
> > --

---
Scarlet One, ADSL 6 Mbps + Telephone, from EUR 29,95...
http://www.scarlet.be/

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/