linux-kernel - Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Tue, 4 Mar 2008 12:51:06 -0800
From:	David Brownell <david-b@...bell.net>
To:	Alan Stern <stern@...land.harvard.edu>
Cc:	Christian Kujau <lists@...dbynature.de>,
	LKML <linux-kernel@...r.kernel.org>, 0x0007@...il.com,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

On Tuesday 04 March 2008, Alan Stern wrote:
> Dave, it seems to me that this must be an example of a race between the 
> iaa watchdog timer expiring and end_unlink_async() running.  It's not 
> good enough for end_unlink_async() to call iaa_watchdog_done(), because 
> on an SMP system the timer may already have fired and the watchdog 
> routine may be spinning on ehci->lock.

Right.


> How about replacing the
> 
>         WARN_ON(!ehci->reclaim);

Or bettter yet, just removing it entirely.  ISTR doing that in some
patches I've not yet sent for merging, and expect that's what my
preferred fix will be ...

- Dave
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/