linux-kernel - Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.DEB.1.00.0803050012090.5974@sheep.housecafe.de>
Date:	Wed, 5 Mar 2008 00:15:31 +0100 (CET)
From:	Christian Kujau <lists@...dbynature.de>
To:	David Brownell <david-b@...bell.net>
cc:	Alan Stern <stern@...land.harvard.edu>,
	LKML <linux-kernel@...r.kernel.org>, 0x0007@...il.com,
	USB list <linux-usb@...r.kernel.org>
Subject: Re: WARNING: at drivers/usb/host/ehci-hcd.c:287

On Tue, 4 Mar 2008, David Brownell wrote:
>>> Or bettter yet, just removing it entirely.  ISTR doing that in some
>>> patches I've not yet sent for merging, and expect that's what my
>>> preferred fix will be ...
>>
>> But removing the WARN_ON won't fix the problem.
>
> It fully resolves the $SUBJECT problem.  :)

...and if it's a safe thing to do, I'm happy with it. I really have no 
clue why shutting up a WARN_ON has no (future) implications but if you 
say so I trust you :)

So now we're down to just:

--- linux-2.6/drivers/usb/host/ehci-hcd.c	2008-03-05 00:08:33.000000000 +0100
+++ linux-2.6/drivers/usb/host/ehci-hcd.c.edited	2008-03-05 00:09:45.000000000 +0100
@@ -284,7 +284,6 @@ static void ehci_iaa_watchdog(unsigned l
  	u32			status, cmd;

  	spin_lock_irqsave (&ehci->lock, flags);
-	WARN_ON(!ehci->reclaim);

  	status = ehci_readl(ehci, &ehci->regs->status);
  	cmd = ehci_readl(ehci, &ehci->regs->command);

Right?

Thank you both for looking into this issue,
Christian.
-- 
BOFH excuse #285:

Telecommunications is upgrading.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/