linux-kernel - Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu indenting

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20080304220029.1f152f00.randy.dunlap@oracle.com>
Date:	Tue, 4 Mar 2008 22:00:29 -0800
From:	Randy Dunlap <randy.dunlap@...cle.com>
To:	Ivo van Doorn <ivdoorn@...il.com>
Cc:	rt2400-devel@...ts.sourceforge.net, linux-wireless@...r.kernel.org,
	Michael Büker <m.bueker@...lin.de>,
	linux-kernel@...r.kernel.org, akpm <akpm@...ux-foundation.org>,
	linville@...driver.com
Subject: Re: [Rt2400-devel] [PATCH] wireless: rt2x00: fix driver menu
 indenting

On Sun, 10 Feb 2008 20:03:25 +0100 Ivo van Doorn wrote:

> On Sunday 10 February 2008, Randy Dunlap wrote:
> > On Sat, 9 Feb 2008 16:23:06 +0100 Michael Büker wrote:
> > 
> > > 2) When selecting "Ralink driver support" (CONFIG_RT2X00), the accompanying 
> > > drivers (CONFIG_RT2400PCI, CONFIG_RT61PC, ...) appear unindented. They should 
> > > be indented by four spaces.
> > 
> > Yes, patch is below.
> > 
> > ---
> > From: Randy Dunlap <randy.dunlap@...cle.com>
> > 
> > Michael Büker <m.bueker@...lin.de> reports that the RT2x00 drivers
> > are not indented as they should be, so use proper dependencies to make
> > them be indented as expected.
> > 
> > Signed-off-by: Randy Dunlap <randy.dunlap@...cle.com>
> 
> Ack-by: Ivo van Doorn <IvDoorn@...il.com>
> 
> ---
> John,
> Could you push this directly into wireless-2.6 and probably upstream as well.
> 
> Thanks.
> 
> Ivo

John, do you have this patch queued somewhere?


> > ---
> >  drivers/net/wireless/rt2x00/Kconfig |   16 ++++++++--------
> >  1 file changed, 8 insertions(+), 8 deletions(-)
> > 
> > --- linux-2.6.24-git21.orig/drivers/net/wireless/rt2x00/Kconfig
> > +++ linux-2.6.24-git21/drivers/net/wireless/rt2x00/Kconfig
> > @@ -11,18 +11,17 @@ config RT2X00
> >  	  will also be created. That library (when the driver is built as
> >  	  a module) will be called "rt2x00lib.ko".
> >  
> > +if RT2X00
> > +
> >  config RT2X00_LIB
> >  	tristate
> > -	depends on RT2X00
> >  
> >  config RT2X00_LIB_PCI
> >  	tristate
> > -	depends on RT2X00
> >  	select RT2X00_LIB
> >  
> >  config RT2X00_LIB_USB
> >  	tristate
> > -	depends on RT2X00
> >  	select RT2X00_LIB
> >  
> >  config RT2X00_LIB_FIRMWARE
> > @@ -39,7 +38,7 @@ config RT2X00_LIB_RFKILL
> >  
> >  config RT2400PCI
> >  	tristate "Ralink rt2400 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select EEPROM_93CX6
> >  	---help---
> > @@ -58,7 +57,7 @@ config RT2400PCI_RFKILL
> >  
> >  config RT2500PCI
> >  	tristate "Ralink rt2500 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select EEPROM_93CX6
> >  	---help---
> > @@ -77,7 +76,7 @@ config RT2500PCI_RFKILL
> >  
> >  config RT61PCI
> >  	tristate "Ralink rt61 pci/pcmcia support"
> > -	depends on RT2X00 && PCI
> > +	depends on PCI
> >  	select RT2X00_LIB_PCI
> >  	select RT2X00_LIB_FIRMWARE
> >  	select EEPROM_93CX6
> > @@ -97,7 +96,7 @@ config RT61PCI_RFKILL
> >  
> >  config RT2500USB
> >  	tristate "Ralink rt2500 usb support"
> > -	depends on RT2X00 && USB
> > +	depends on USB
> >  	select RT2X00_LIB_USB
> >  	---help---
> >  	  This is an experimental driver for the Ralink rt2500 wireless chip.
> > @@ -106,7 +105,7 @@ config RT2500USB
> >  
> >  config RT73USB
> >  	tristate "Ralink rt73 usb support"
> > -	depends on RT2X00 && USB
> > +	depends on USB
> >  	select RT2X00_LIB_USB
> >  	select RT2X00_LIB_FIRMWARE
> >  	---help---
> > @@ -128,3 +127,4 @@ config RT2X00_DEBUG
> >  	---help---
> >  	  Enable debugging output for all rt2x00 modules
> >  
> > +endif


---
~Randy
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/