linux-kernel - Re: [PATCH] include/asm-arm - use angle brackets for includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080305074723.GA19674@flint.arm.linux.org.uk>
Date:	Wed, 5 Mar 2008 07:47:23 +0000
From:	Russell King <rmk+lkml@....linux.org.uk>
To:	Joe Perches <joe@...ches.com>
Cc:	Nicolas Pitre <nico@....org>, LKML <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] include/asm-arm - use angle brackets for includes

To: Russell King <rmk+kernel@....linux.org.uk>, Nicolas Pitre <nico@....org>
Cc: linux-arm-kernel@...ts.arm.linux.org.uk,
        LKML <linux-kernel@...r.kernel.org>

No idea why you're sending this to Nicolas, yet it touches s3cXXXX stuff
which is Ben Dooks, who has been omitted from the above.

On Tue, Mar 04, 2008 at 04:46:18PM -0800, Joe Perches wrote:
> Signed-off-by: Joe Perches <joe@...ches.com

This is not a proper signed off - please use both angle brackets. 8)

> 
> include/asm-arm/plat-s3c/uncompress.h |    4 ++--
>  include/asm-arm/proc-fns.h            |    4 ++--
>  2 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/include/asm-arm/plat-s3c/uncompress.h b/include/asm-arm/plat-s3c/uncompress.h
> index b5e6208..19b9eda 100644
> --- a/include/asm-arm/plat-s3c/uncompress.h
> +++ b/include/asm-arm/plat-s3c/uncompress.h
> @@ -27,8 +27,8 @@ static void arch_detect_cpu(void);
>  
>  /* defines for UART registers */
>  
> -#include "asm/plat-s3c/regs-serial.h"
> -#include "asm/plat-s3c/regs-watchdog.h"
> +#include <asm/plat-s3c/regs-serial.h>
> +#include <asm/plat-s3c/regs-watchdog.h>
>  
>  /* working in physical space... */
>  #undef S3C2410_WDOGREG
> diff --git a/include/asm-arm/proc-fns.h b/include/asm-arm/proc-fns.h
> index a4ce457..75ec760 100644
> --- a/include/asm-arm/proc-fns.h
> +++ b/include/asm-arm/proc-fns.h
> @@ -214,9 +214,9 @@
>  #ifndef __ASSEMBLY__
>  
>  #ifndef MULTI_CPU
> -#include "asm/cpu-single.h"
> +#include <asm/cpu-single.h>
>  #else
> -#include "asm/cpu-multi32.h"
> +#include <asm/cpu-multi32.h>
>  #endif
>  
>  #include <asm/memory.h>
> 
> 

-- 
Russell King
 Linux kernel    2.6 ARM Linux   - http://www.arm.linux.org.uk/
 maintainer of:
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/