| lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
|
Open Source and information security mailing list archives
| ||
|
Message-ID: <47CF24B7.7050104@snapgear.com> Date: Thu, 06 Mar 2008 08:54:47 +1000 From: Greg Ungerer <gerg@...pgear.com> To: Jeff Garzik <jeff@...zik.org> CC: torvalds@...ux-foundation.org, linux-kernel@...r.kernel.org Subject: Re: [M68KNOMMU]: fix fec driver interrupt races Hi Jeff, Jeff Garzik wrote: > Greg Ungerer wrote: >> The FEC driver has a common interrupt handler for all interrupt event >> types. It is raised on a number of distinct interrupt vectors. >> This handler can't be re-entered while processing an interrupt, so >> make sure all requested vectors are flagged as IRQF_DISABLED. >> >> Signed-off-by: Greg Ungerer <gerg@...inux.org> > > NAK -- add spinlocks to your interrupt handling like you are supposed to A better fix is to use the separate vectors, avoiding spinlocks in most cases. But this is a simple immediate fix for 2.6.25. The better solution is being worked on, but it needs some reasonable testing before it is ready for inclusion, and that won't be till post 2.6.25. (This is a regression, fixes in the m68knommu interrupt subsystem exposed this). Regards Greg ------------------------------------------------------------------------ Greg Ungerer -- Chief Software Dude EMAIL: gerg@...pgear.com Secure Computing Corporation PHONE: +61 7 3435 2888 825 Stanley St, FAX: +61 7 3891 3630 Woolloongabba, QLD, 4102, Australia WEB: http://www.SnapGear.com -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@...r.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists