linux-kernel - Re: [PATCH] add strncmp to PowerPC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <d495403c2b5f700be085c965746cd211@kernel.crashing.org>
Date:	Wed, 5 Mar 2008 06:26:06 +0100
From:	Segher Boessenkool <segher@...nel.crashing.org>
To:	Paul Mackerras <paulus@...ba.org>
Cc:	benh@...nel.crashing.org, LKML <linux-kernel@...r.kernel.org>,
	linuxppc-dev@...abs.org, Steven Rostedt <rostedt@...dmis.org>
Subject: Re: [PATCH] add strncmp to PowerPC

>> Do we have any indication that it performs better than the C one ?
>
> I would expect it to, given that the assembler one has two branches in
> the per-byte loop compared to 3 in the C version.

But really, does it matter for strncmp() in the kernel?

Anyway, this asm code has bugs, as do both the current C version in the
kernel, and the code I posted.  We need to do better :-)


Segher

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/