[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <m1ablc3eo3.fsf@ebiederm.dsl.xmission.com>
Date: Wed, 05 Mar 2008 16:59:56 -0700
From: ebiederm@...ssion.com (Eric W. Biederman)
To: paulmck@...ux.vnet.ibm.com
Cc: Pavel Emelyanov <xemul@...nvz.org>,
Andrew Morton <akpm@...ux-foundation.org>,
David Miller <davem@...emloft.net>,
Linux Netdev List <netdev@...r.kernel.org>,
Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
"Eric W. Biederman" <ebiederm@...ssion.com>,
Alexey Dobriyan <adobriyan@...nvz.org>
Subject: Re: [PATCH] Make /proc/net a symlink on /proc/self/net
>>
>> +static struct net *get_proc_task_net(struct inode *dir)
>> +{
>> + struct task_struct *task;
>> + struct nsproxy *ns;
>> + struct net *net = NULL;
>> +
>> + rcu_read_lock();
>> + task = get_proc_task(dir);
>
> This implies a get_task_struct(), as get_proc_task() invokes get_proc_task()
> which invokes get_pid_task() which invokes get_task_struct().
>
> I don't see the corresponding put_task_struct() -- what am I missing here?
You aren't. However we can easily make this:
task = pid_task(proc_pid(dir), PIDTYPE_PID);
And we won't need to increment the count on the task_struct.
Good catch.
>> + if (task != NULL) {
>> + ns = task_nsproxy(task);
>> + if (ns != NULL)
>> + net = get_net(ns->net_ns);
>> + }
>> + rcu_read_unlock();
>> +
>> + return net;
>> +}
>> +
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists