linux-kernel - Re: [PATCH 05/18] MMC: OMAP: Introduce new multislot structure and change driver to use it

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080306073432.4206d50e@mjolnir.drzeus.cx>
Date:	Thu, 6 Mar 2008 07:34:32 +0100
From:	Pierre Ossman <drzeus-list@...eus.cx>
To:	me@...ipebalbi.com
Cc:	Carlos Aguiar <carlos.aguiar@...t.org.br>,
	Tony Lindgren <tony@...mide.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 05/18] MMC: OMAP: Introduce new multislot structure and
 change driver to use it

On Wed, 5 Mar 2008 22:54:09 +0200
Felipe Balbi <me@...ipebalbi.com> wrote:

> 
> Not nightmare. OMAP1/2 have mmc/sd/sdio controller supporting one or
> more mmc cards sharing the same bus.
> 

Do you have some docs to that effect? All that's been presented to me so far is a standard, one port controller with a mux in front of it. Under that definition, all controllers support an infinite number of cards.

> > > +
> > > +	mmc->caps = MMC_CAP_MULTIWRITE | MMC_CAP_MMC_HIGHSPEED |
> > > +		    MMC_CAP_SD_HIGHSPEED;
> > 
> > This is also unrelated. From what I've seen, the OMAP is a SD controller and does not support high speed MMC. The fact that you also conditionally set the max frequency later also suggests that this code is entirely incorrect.
> > 
> 
> Not true. I can't show you not even parts of the technical documentation
> but OMAP has mmc/sd/sdio controller. On OMAP1/2 it handles several mmc
> cards sharing the same bus.
> 

I'm afraid empirical data is insufficient. Show me a data sheet saying that OMAP controllers are designed in accordance with the newer MMC specs and I'll be happy.

And you'll have to do a lot better than that to convince me that older OMAP controllers are designed for standards that were written after the chips were released (i.e. high speed bus timings).

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/