linux-kernel - Re: [RFC, PATCH 6/6] ext3: do not write to the disk when mounting a dirty read-only filesystem

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <e9e943910803060319y1f538a68y59bea3fae4b88bb9@mail.gmail.com>
Date:	Thu, 6 Mar 2008 11:19:03 +0000
From:	"Duane Griffin" <duaneg@...da.com>
To:	"Andreas Dilger" <adilger@....com>
Cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	"Theodore Tso" <tytso@....edu>, sct@...hat.com,
	akpm@...ux-foundation.org
Subject: Re: [RFC, PATCH 6/6] ext3: do not write to the disk when mounting a dirty read-only filesystem

On 06/03/2008, Andreas Dilger <adilger@....com> wrote:
> On Mar 06, 2008  01:59 +0000, Duane Griffin wrote:
>  > NOTE: For now I'm simply preventing filesystems requiring recovery from being
>  > remounted read-write. This breaks booting with an uncleanly mounted root
>  > filesystem!
>
> I was going to ask about this - not being able to remount rw is a serious
> problem because many users have only the root filesystem and this
> limitation basically prevents this patch from being landable.

Yep, I agree. I wanted to post this as an RFC now to get feedback on
the overall approach. I'll try and get remount support in there ASAP
and post another version.

>  I'd suggest if the filesystem is going to be remounted read/write that
>  the journal mapping be discarded and the journal replayed.  Depending
>  on how you do the mapping it may be necessary to invalidate all of the
>  pages in the cache so that they don't reference the blocks in the journal.

That was along the lines I was thinking of, too. Thanks for mentioning
invalidating the page cache -- I'll make sure that doesn't get
overlooked.

>  Cheers, Andreas

Cheers,
Duane.

-- 
"I never could learn to drink that blood and call it wine" - Bob Dylan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/