[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20080306121313.GA19613@elte.hu>
Date: Thu, 6 Mar 2008 13:13:13 +0100
From: Ingo Molnar <mingo@...e.hu>
To: Glauber Costa <glommer@...il.com>
Cc: Glauber Costa <gcosta@...hat.com>, linux-kernel@...r.kernel.org,
akpm@...ux-foundation.org, tglx@...utronix.de
Subject: Re: [PATCH 1/1] export native versions of machine_ops functions
* Glauber Costa <glommer@...il.com> wrote:
> > i'd like to do this only if there are actual users - otherwise
> > we'll get a trickle of "make needlessly global functions static"
> > patches a few weeks later ;-)
>
> KVM is a user for that. Because it registers a memory area in which
> the host will be continually writting to (the clock), when it
> shutdown, the host have no way to know it has to stop. If you're
> really shutting down, there's no problem. But if you're kexecing, for
> example, the host will keep writting to a random memory area after the
> new kernel installs.
i mean, i agree in general - but KVM is not a user of any of those
currently static functions. So i've applied your patch but lets make
sure those functions really get used :)
Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists