[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <1865922a0803060632kb63405fj3d255472fb2e555f@mail.gmail.com>
Date: Thu, 6 Mar 2008 16:32:51 +0200
From: "Ahmed S. Darwish" <darwish.07@...il.com>
To: "James Morris" <jmorris@...ei.org>
Cc: "Chris Wright" <chrisw@...s-sol.org>,
"Stephen Smalley" <sds@...ho.nsa.gov>,
"Eric Paris" <eparis@...isplace.org>,
"Casey Schaufler" <casey@...aufler-ca.com>,
"Paul Moore" <paul.moore@...com>,
"Alexey Dobriyan" <adobriyan@...ru>,
"Andrew Morton" <akpm@...ux-foundation.org>,
Linus <torvalds@...ux-foundation.org>,
LKML <linux-kernel@...r.kernel.org>,
LSM-ML <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH -v8 -rc3] Security: Introduce security= boot parameter
Hi James,
On Thu, Mar 6, 2008, James Morris <jmorris@...ei.org> wrote:
> On Thu, 6 Mar 2008, Ahmed S. Darwish wrote:
>
> > Handle Andrew's concerns:
> > - Use __init and __initdata in appropriate places.
> > - Do not rely upon dummy_ops layout, use C99 initializations.
> > - Use DEFINE_SPINLOCK instead of dynamic initialization.
>
> The spinlock is not needed now, if security_module_enable() can only be
> called during boot via an initcall.
>
Will do.
Would you mind answering my confusions below so I can do the change
with good understanding ?
I see preempt_disable() before calling security and vfs_caches init,
but what will prevent two processors/cores from executing
security_module_enable() concurrently (thus possibly corrupting
chosen_lsm) ?
security_module_enable() is also now used in __init init_smk_fs().
Or the init path got executed serially ?
Thank you,
--
Ahmed S. Darwish
Homepage: http://darwish.07.googlepages.com
Blog: http://darwish-07.blogspot.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists