linux-kernel - Re: [2.6 patch] SCSI_AIC94XX must depend on SCSI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1204835467.3062.42.camel@localhost.localdomain>
Date:	Thu, 06 Mar 2008 14:31:07 -0600
From:	James Bottomley <James.Bottomley@...senPartnership.com>
To:	Adrian Bunk <bunk@...nel.org>
Cc:	Toralf Förster <toralf.foerster@....de>,
	linux-scsi@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [2.6 patch] SCSI_AIC94XX must depend on SCSI

On Thu, 2008-03-06 at 22:22 +0200, Adrian Bunk wrote:
> This patch fixes the following build error reported by Toralf Förster:
> 
> <--  snip  -->
> 
> ...
>   MODPOST 243 modules
> ERROR: "sas_bios_param" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_change_queue_type" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_change_queue_depth" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_target_destroy" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_target_alloc" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_destroy" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_configure" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_eh_bus_reset_handler" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_eh_device_reset_handler" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_queuecommand" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_ioctl" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_register_ha" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_domain_attach_transport" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_ssp_task_response" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_slave_alloc" [drivers/scsi/mvsas.ko] undefined!
> ERROR: "sas_unregister_ha" [drivers/scsi/mvsas.ko] undefined!
> make[1]: *** [__modpost] Error 1
> 
> <--  snip  -->
> 
> Signed-off-by: Adrian Bunk <bunk@...nel.org>
> 
> ---
> --- a/drivers/scsi/aic94xx/Kconfig
> +++ b/drivers/scsi/aic94xx/Kconfig
> @@ -26,7 +26,7 @@
>  
>  config SCSI_AIC94XX
>  	tristate "Adaptec AIC94xx SAS/SATA support"
> -	depends on PCI
> +	depends on SCSI && PCI
>  	select SCSI_SAS_LIBSAS
>  	select FW_LOADER

This doesn't look to be a fix for your error: the symbols you've listed
as missing are all libsas ones, not core SCSI ones.  Also they're all
claiming to be missing from mvsas, not aic94xx.  There's something else
about the configuration that produced this error.

James


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/