[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <Pine.LNX.4.64.0803061453360.16212@schroedinger.engr.sgi.com>
Date: Thu, 6 Mar 2008 14:56:42 -0800 (PST)
From: Christoph Lameter <clameter@....com>
To: Nick Piggin <npiggin@...e.de>
cc: David Miller <davem@...emloft.net>, netdev@...r.kernel.org,
linux-kernel@...r.kernel.org, yanmin_zhang@...ux.intel.com,
dada1@...mosbay.com
Subject: Re: [rfc][patch 1/3] slub: fix small HWCACHE_ALIGN alignment
On Thu, 6 Mar 2008, Nick Piggin wrote:
> There looks like definitely some networking slabs that pass the flag
> and can be non-power-of-2. And don't forget cachelines can be anywhere
> up to 256 bytes in size. So yeah it definitely makes sense to merge
> the patch and then examine the callers if you feel strongly about it.
Just do not like to add fluff that has basically no effect. I just tried
to improve things by not doing anything special if we cannot cacheline
align object. Least surprise (at least for me). It is bad enough that we
just decide to ignore the request for alignment for small caches.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists