linux-kernel - Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <446410.44539.qm@web36709.mail.mud.yahoo.com>
Date:	Wed, 5 Mar 2008 18:29:43 -0800 (PST)
From:	Alex Dubov <oakad@...oo.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 11/11] memstick: add support for JMicron jmb38x MemoryStick host controller

--- Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Wed,  5 Mar 2008 03:02:28 +1100
> oakad@...mail.com.au wrote:
> 
> > +static void jmb38x_ms_reset(struct jmb38x_ms_host *host)
> > +{
> > +	unsigned int host_ctl = readl(host->addr + HOST_CONTROL);
> > +
> > +	writel(host_ctl | HOST_CONTROL_RESET_REQ | HOST_CONTROL_RESET,
> > +	       host->addr + HOST_CONTROL);
> > +
> > +	while (HOST_CONTROL_RESET_REQ
> > +	       & (host_ctl = readl(host->addr + HOST_CONTROL))) {
> 
> host_ctl is written to but is not used again.

It was supposed to be used in the dev_dbg printout.

> 
> > +		ndelay(100);
> > +		dev_dbg(&host->chip->pdev->dev, "reset\n");
> > +	}
> > +
> > +	writel(INT_STATUS_ALL, host->addr + INT_STATUS_ENABLE);
> > +	writel(INT_STATUS_ALL, host->addr + INT_SIGNAL_ENABLE);
> > +
> > +	dev_dbg(&host->chip->pdev->dev, "reset\n");
> > +}
> 



      ____________________________________________________________________________________
Be a better friend, newshound, and 
know-it-all with Yahoo! Mobile.  Try it now.  http://mobile.yahoo.com/;_ylt=Ahu06i62sR8HDtDypao8Wcj9tAcJ 

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/