linux-kernel - Re: [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <996921.54635.qm@web36711.mail.mud.yahoo.com>
Date:	Wed, 5 Mar 2008 18:30:46 -0800 (PST)
From:	Alex Dubov <oakad@...oo.com>
To:	Linux kernel mailing list <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH 05/11] tifm: fix the MemoryStick host fifo handling code

--- Andrew Morton <akpm@...ux-foundation.org> wrote:

> On Wed,  5 Mar 2008 03:02:22 +1100
> oakad@...mail.com.au wrote:
> 
> > +			buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
> 
> I am unable to convince myself that this driver always has local IRQs
> disabled when altering the KM_BIO_SRC_IRQ slot.  Does it?
> 

diff did rather bad job with this patch. The place in question looks like:


211: local_irq_save(flags);
212: buf = kmap_atomic(pg, KM_BIO_SRC_IRQ) + p_off;
....
....
223: kunmap_atomic(buf - p_off, KM_BIO_SRC_IRQ);
224: local_irq_restore(flags);



      ____________________________________________________________________________________
Never miss a thing.  Make Yahoo your home page. 
http://www.yahoo.com/r/hs
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/