linux-kernel - Re: [PATCH] [6/13] Core maskable allocator

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080307111452.GA7365@one.firstfloor.org>
Date:	Fri, 7 Mar 2008 12:14:52 +0100
From:	Andi Kleen <andi@...stfloor.org>
To:	Johannes Weiner <hannes@...urebad.de>
Cc:	Andi Kleen <andi@...stfloor.org>, linux-kernel@...r.kernel.org,
	linux-mm@...ck.org
Subject: Re: [PATCH] [6/13] Core maskable allocator

> > +		}
> > +#endif
> > +		p = alloc_pages(gfp_mask|__GFP_NOWARN, order);
> 
> ... isn't this a leak here?

You're right -- this needs a check. Weird wonder why the tests didn't
catch that.

Thanks,
-Andi
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/