linux-kernel - Re: [PATCH -v8b -rc3] Security: Introduce security= boot parameter

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Xine.LNX.4.64.0803071218400.25703@us.intercode.com.au>
Date:	Fri, 7 Mar 2008 12:42:03 +1100 (EST)
From:	James Morris <jmorris@...ei.org>
To:	"Ahmed S. Darwish" <darwish.07@...il.com>
cc:	Chris Wright <chrisw@...s-sol.org>,
	Stephen Smalley <sds@...ho.nsa.gov>,
	Eric Paris <eparis@...isplace.org>,
	Casey Schaufler <casey@...aufler-ca.com>,
	Paul Moore <paul.moore@...com>,
	Alexey Dobriyan <adobriyan@...ru>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Linus <torvalds@...ux-foundation.org>,
	LKML <linux-kernel@...r.kernel.org>,
	LSM-ML <linux-security-module@...r.kernel.org>
Subject: Re: [PATCH -v8b -rc3] Security: Introduce security= boot parameter

On Thu, 6 Mar 2008, Ahmed S. Darwish wrote:

> + * Each LSM must pass this method before registering its own operations
> + * to avoid security registration races. This method may also be used
> + * to check if your LSM is currently loaded.

The 2nd sentence is no longer correct in general, as the function can only 
be called during init.  See a fixup patch below.

Otherwise, looks good!

Acked-by: James Morris <jmorris@...ei.org>

I've applied the patch and a comment fixup to
git://git.kernel.org/pub/scm/linux/kernel/git/jmorris/security-testing-2.6.git#next

commit d6bb3bacedb68aa41ea7598e0cf1bef33cebbcc9
Author: James Morris <jmorris@...ei.org>
Date:   Fri Mar 7 12:23:49 2008 +1100

    security: fix up documentation for security_module_enable
    
    security_module_enable() can only be called during kernel init.
    
    Signed-off-by: James Morris <jmorris@...ei.org>

diff --git a/security/security.c b/security/security.c
index 4377b00..8aa2f54 100644
--- a/security/security.c
+++ b/security/security.c
@@ -83,7 +83,7 @@ __setup("security=", choose_lsm);
  *
  * Each LSM must pass this method before registering its own operations
  * to avoid security registration races. This method may also be used
- * to check if your LSM is currently loaded.
+ * to check if your LSM is currently loaded during kernel initialization.
  *
  * Return true if:
  *     -The passed LSM is the one chosen by user at boot time,




-- 
James Morris
<jmorris@...ei.org>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/