linux-kernel - Re: [PATCH][v2] Modify loop device to be able to manage partitions of the disk image

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <1204893909.4315.32.camel@frecb07144>
Date:	Fri, 07 Mar 2008 13:45:09 +0100
From:	Laurent Vivier <Laurent.Vivier@...l.net>
To:	Andreas Schwab <schwab@...e.de>
Cc:	linux-kernel <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH][v2] Modify loop device to be able to manage partitions
	of the disk image


Le vendredi 07 mars 2008 à 13:33 +0100, Andreas Schwab a écrit :
> Laurent Vivier <Laurent.Vivier@...l.net> writes:
> 
> > +static int __init max_part_setup(char *str)
> > +{
> > +	loop_max_part = simple_strtol(str, NULL, 0);
> > +	if (loop_max_part > (1UL << (MINORBITS - 1))) {
> > +		/* we must keep at least one bit for loop device number */
> > +		printk(KERN_ERR
> > +			"loop: loop_max_part cannot be greater than %d\n",
> > +			1UL << (MINORBITS - 1));
> 
> Since the argument is of type unsigned long you should use %ld or %lu.

Yes, I wait for some more comments and I will re-send a [v3].

Laurent
-- 
----------------- Laurent.Vivier@...l.net  ------------------
"Programmers who subconsciously view themselves as artists
 will enjoy what they do and will do it better." D. Knuth

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/