linux-kernel - Re: [PATCH] ia64: fix getpid and set_tid_address fast system calls for pid namespaces

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20080307135120.GA29388@parisc-linux.org>
Date:	Fri, 7 Mar 2008 06:51:20 -0700
From:	Matthew Wilcox <matthew@....cx>
To:	Pavel Emelyanov <xemul@...nvz.org>
Cc:	Andrew Morton <akpm@...ux-foundation.org>,
	"Luck, Tony" <tony.luck@...el.com>, linux-ia64@...r.kernel.org,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] ia64: fix getpid and set_tid_address fast system calls for pid namespaces

On Fri, Mar 07, 2008 at 04:23:13PM +0300, Pavel Emelyanov wrote:
> @@ -34,6 +35,9 @@
>  	DEFINE(SIGFRAME_SIZE, sizeof (struct sigframe));
>  	DEFINE(UNW_FRAME_INFO_SIZE, sizeof (struct unw_frame_info));
>  
> +	BUILD_BUG_ON(sizeof(struct upid) != 32);
> +	DEFINE(IA64_UPID_SHIFT, 5);
> +
>  	BLANK();
>  
>  	DEFINE(TI_FLAGS, offsetof(struct thread_info, flags));

This might work better with ilog2().  Something like this perhaps?

	BUILD_BUG_ON(!is_power_of_2(sizeof(struct upid)))
	DEFINE(IA64_UPID_SHIFT, ilog2(sizeof(struct upid)))

-- 
Intel are signing my paycheques ... these opinions are still mine
"Bill, look, we understand that you're interested in selling us this
operating system, but compare it to ours.  We can't possibly take such
a retrograde step."
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/