[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <47D18B89.4000706@intel.com>
Date: Fri, 07 Mar 2008 10:38:01 -0800
From: "Kok, Auke" <auke-jan.h.kok@...el.com>
To: Joe Perches <joe@...ches.com>
CC: e1000-devel@...ts.sourceforge.net,
xfs-masters <xfs-masters@....sgi.com>,
kernel-janitors@...r.kernel.org, Julia Lawall <julia@...u.dk>,
linux-kernel@...r.kernel.org
Subject: Re: [E1000-devel] [PATCH] drivers/net: convert & to &&
Joe Perches wrote:
> On Thu, 2008-03-06 at 10:07 -0800, Kok, Auke wrote:
>> (which, BTW also could use the uint32_t -> u32 (etc) changes... while you're at it)
>
> I think this does what you want:
>
> for size in "8" "16" "32" "64" ; do \
> sed -r -i -e 's/\bu_{0,1}int'$size'_t\b/u'$size'/g' \
> $(grep -rPlw --include=*.[ch] 'u_{0,1}int'$size'_t' drivers/net/e1000 drivers/net/ixgb); done
>
> But why? boolean_t is used by 3 subsystems with local typedefs.
> These others are much more frequently used by kernel source.
afaik they're really meant for userspace related code and don't belong in our
driver from that perspective.
> $ grep -rPlw --include=*.[ch] "u{0,1}_{0,1}int(8|16|32|64)_t" * | wc -l
> 876
yes, a lot of that *is* userspace related code.
do the same search in drivers/net/ .... you'll see the only drivers using this for
everything is our old drivers...
Auke
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists