linux-kernel - Re: [PATCH 3/3] jbd2: only create debugfs and stats entries if cache initialisation is successful

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-id: <20080307212426.GF1881@webber.adilger.int>
Date:	Fri, 07 Mar 2008 14:24:26 -0700
From:	Andreas Dilger <adilger@....com>
To:	Duane Griffin <duaneg@...da.com>
Cc:	linux-ext4@...r.kernel.org, linux-kernel@...r.kernel.org,
	Theodore Tso <tytso@....edu>, sct@...hat.com,
	akpm@...ux-foundation.org, adilger@...sterfs.com
Subject: Re: [PATCH 3/3] jbd2: only create debugfs and stats entries if	cache
 initialisation is successful

On Mar 07, 2008  01:31 +0000, Duane Griffin wrote:
> jbd2 debugfs and stats entries should only be created if cache initialisation
> is successful. At the moment they are being created unconditionally which will
> leave them dangling if cache (and hence module) initialisation fails.
> 
> Signed-off-by: Duane Griffin <duaneg@...da.com>

Acked-by: Andreas Dilger <adilger@....com>

> ---
>  fs/jbd2/journal.c |    8 +++++---
>  1 files changed, 5 insertions(+), 3 deletions(-)
> 
> diff --git a/fs/jbd2/journal.c b/fs/jbd2/journal.c
> index 0d8a595..9d48419 100644
> --- a/fs/jbd2/journal.c
> +++ b/fs/jbd2/journal.c
> @@ -2315,10 +2315,12 @@ static int __init journal_init(void)
>  	BUILD_BUG_ON(sizeof(struct journal_superblock_s) != 1024);
>  
>  	ret = journal_init_caches();
> -	if (ret != 0)
> +	if (ret == 0) {
> +		jbd2_create_debugfs_entry();
> +		jbd2_create_jbd_stats_proc_entry();
> +	} else {
>  		jbd2_journal_destroy_caches();
> -	jbd2_create_debugfs_entry();
> -	jbd2_create_jbd_stats_proc_entry();
> +	}
>  	return ret;
>  }
>  
> -- 
> 1.5.3.7
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
> the body of a message to majordomo@...r.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Cheers, Andreas
--
Andreas Dilger
Sr. Staff Engineer, Lustre Group
Sun Microsystems of Canada, Inc.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/