[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <a8e1da0803061907k72785f10t2dcb98ca9829e2d8@mail.gmail.com>
Date: Fri, 7 Mar 2008 11:07:48 +0800
From: "Dave Young" <hidave.darkstar@...il.com>
To: paulmck@...ux.vnet.ibm.com
Cc: "Jike Song" <albcamus@...il.com>,
"Linux Kernel" <linux-kernel@...r.kernel.org>
Subject: Re: 2.6.25-rc4 rcupreempt.h WARNINGs while suspend/resume
On Fri, Mar 7, 2008 at 12:27 AM, Paul E. McKenney
<paulmck@...ux.vnet.ibm.com> wrote:
>
> On Thu, Mar 06, 2008 at 07:08:55PM +0800, Dave Young wrote:
> > On Thu, Mar 6, 2008 at 11:20 AM, Dave Young <hidave.darkstar@...il.com> wrote:
> > > On Thu, Mar 6, 2008 at 10:28 AM, Paul E. McKenney
> > >
> > > <paulmck@...ux.vnet.ibm.com> wrote:
> > > >
> > > > On Thu, Mar 06, 2008 at 10:11:26AM +0800, Jike Song wrote:
> > > > > On Thu, Mar 6, 2008 at 12:55 AM, Paul E. McKenney
> > > > > <paulmck@...ux.vnet.ibm.com> wrote:
> > > > > > Could you please try applying Karsten Wiese's patch to see if it
> > > > > > fixes the WARNINGs? See http://lkml.org/lkml/2008/2/26/386 for
> > > > > > the patch.
> > > > > >
> > > > > > Thanx, Paul
> > > > >
> > > > > Yes, the WARNING disappears with Karsten's patch applied.
> > > > > Thanks.
> > >
> > > Confirmed
> > >
> > >
> > >
> > > >
> > > > Good to hear!!! I believe that Karsten's patch is on its way in,
> > > > so hopefully that will clear things up.
> >
> > Hi, paul
> >
> > My syslog became a 2G size big file yestoday due to the warnings.
> > How about change the WARN_ON to WARN_ON_ONCE?
>
> Hello, Dave,
>
> I might be convinced to make this change for 2.6.26, but the condition
> that the WARN_ON() is complaining about is quite serious, so I don't
> want to take a chance on it getting lost in the noise in the 2.6.25
> series.
>
> Seem reasonable?
IMHO, WARN_ON_ONCE is enough for my eyes :)
>
> Better yet, is there some sort of time-limited WARN_ON that kicks out
> a message at most once per second or some such? Enough to definitely
> be noticed, but not enough to bring the machine to its knees?
Seems there's no such functions/macros, but is is really needed?
>
> Thanx, Paul
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists