linux-kernel - Re: Commit 9f10d9ee breaks CD mounting/burning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:	Thu, 06 Mar 2008 16:21:53 -0800
From:	walt <w41ter@...il.com>
To:	linux-ide@...r.kernel.org
CC:	linux-kernel@...r.kernel.org,
	Borislav Petkov <petkovbb@...glemail.com>
Subject: Re: Commit 9f10d9ee breaks CD mounting/burning

Bartlomiej Zolnierkiewicz wrote:
> On Thursday 06 March 2008, walt wrote:
>> Hi Bartolmiej,
>>
>> For me, this commit causes the problem it's intended to fix:
>>
>> commit 9f10d9ee0ac6d79d7bc8b9a158bf4a29322d84d3
>> Author: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
>> Date:   Tue Feb 26 21:50:35 2008 +0100
>>
>>       ide-cd: fix 'ireason' handling for REQ_TYPE_ATA_PC requests


> Does the following patch help?
>
> [ Borislav, please take a look and double check that it is OK. ]
>
> From: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> Subject: [PATCH] ide-cd: mark REQ_TYPE_ATA_PC write requests with REQ_RW flag
>
> It turned out that REQ_TYPE_ATA_PC write requests were not marked as such
> (the previous commit assumed them to be).
>
> Reported-by: walt<w41ter@...il.com>
> Cc: Borislav Petkov<petkovbb@...glemail.com>
> Signed-off-by: Bartlomiej Zolnierkiewicz<bzolnier@...il.com>
> ---
>   drivers/ide/ide-cd_ioctl.c |    4 ++++
>   1 file changed, 4 insertions(+)
>
> Index: b/drivers/ide/ide-cd_ioctl.c
> ===================================================================
> --- a/drivers/ide/ide-cd_ioctl.c
> +++ b/drivers/ide/ide-cd_ioctl.c
> @@ -457,6 +457,10 @@ int ide_cdrom_packet(struct cdrom_device
>   	   layer. the packet must be complete, as we do not
>   	   touch it at all. */
>   	ide_cd_init_rq(drive,&req);
> +
> +	if (cgc->data_direction == CGC_DATA_WRITE)
> +		req.cmd_flags |= REQ_RW;
> +
>   	memcpy(req.cmd, cgc->cmd, CDROM_PACKET_SIZE);
>   	if (cgc->sense)
>   		memset(cgc->sense, 0, sizeof(struct request_sense));
>

It's perfect, thanks!
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/