[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <alpine.DEB.1.00.0803062115010.26462@chino.kir.corp.google.com>
Date: Thu, 6 Mar 2008 21:15:33 -0800 (PST)
From: David Rientjes <rientjes@...gle.com>
To: KAMEZAWA Hiroyuki <kamezawa.hiroyu@...fujitsu.com>
cc: balbir@...ux.vnet.ibm.com, Paul Menage <menage@...gle.com>,
Andrew Morton <akpm@...ux-foundation.org>,
Pavel Emelianov <xemul@...nvz.org>,
Hugh Dickins <hugh@...itas.com>,
Sudhir Kumar <skumar@...ux.vnet.ibm.com>,
YAMAMOTO Takashi <yamamoto@...inux.co.jp>, lizf@...fujitsu.com,
linux-kernel@...r.kernel.org, taka@...inux.co.jp,
linux-mm@...ck.org
Subject: Re: [PATCH] Add cgroup support for enabling controllers at boot
time
On Fri, 7 Mar 2008, KAMEZAWA Hiroyuki wrote:
> > David Rientjes wrote:
> > > On Fri, 7 Mar 2008, Balbir Singh wrote:
> > >
> > >> @@ -3010,3 +3020,16 @@ static void cgroup_release_agent(struct
> > >> spin_unlock(&release_list_lock);
> > >> mutex_unlock(&cgroup_mutex);
> > >> }
> > >> +
> > >> +static int __init cgroup_disable(char *str)
> > >> +{
> > >> + int i;
> > >> + for (i = 0; i < CGROUP_SUBSYS_COUNT; i++) {
> > >> + struct cgroup_subsys *ss = subsys[i];
> > >> + if (!strcmp(str, ss->name)) {
> > >> + ss->disabled = 1;
> > >> + break;
> > >> + }
> > >> + }
> > >> +}
> > >> +__setup("cgroup_disable=", cgroup_disable);
> > >
> > > This doesn't handle spaces very well, so isn't it possible for the name of
> > > a current or future cgroup subsystem to be specified after cgroup_disable=
> > > on the command line and have it disabled by accident?
> > >
> >
> Hmm, cmdline like
>
> cgroup_disable=cpu,memory, ...
>
> should be written as
>
> cgroup_disable=cpu cgroup_disable=memory ....
>
Or just set the first space following cgroup_disable= to '\0' and you're
done. strcmp() will take care of the rest.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Powered by blists - more mailing lists