linux-kernel - Re: quicklists confuse meminfo

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.1.00.0803091257190.3099@apollo.tec.linutronix.de>
Date:	Sun, 9 Mar 2008 13:00:05 +0100 (CET)
From:	Thomas Gleixner <tglx@...utronix.de>
To:	KOSAKI Motohiro <kosaki.motohiro@...fujitsu.com>
cc:	LKML <linux-kernel@...r.kernel.org>,
	Linus Torvalds <torvalds@...ux-foundation.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	Ingo Molnar <mingo@...e.hu>,
	Christoph Lameter <clameter@....com>,
	Bart Van Assche <bart.vanassche@...il.com>
Subject: Re: quicklists confuse meminfo

On Sun, 9 Mar 2008, KOSAKI Motohiro wrote:
> Hi
> 
> in general, I like this patch and I think this is very useful.
> but I don't like #ifdef ;)

/me neither :)
 
> > +#ifdef CONFIG_QUICKLIST
> > +		"QuickLists:   %8lu kB\n"
> > +#endif
> > +		,K(i.totalram),
> >  		K(i.freeram),
> >  		K(i.bufferram),
> >  		K(cached),
> > @@ -215,6 +220,9 @@ static int meminfo_read_proc(char *page,
> >  		(unsigned long)VMALLOC_TOTAL >> 10,
> >  		vmi.used >> 10,
> >  		vmi.largest_chunk >> 10
> > +#ifdef CONFIG_QUICKLIST
> > +		,K(quicklist_total_size())
> > +#endif
> 
> Do you dislike my following patch?

I like it. I'm just not sure about the accounting of cached memory in
general, though quicklists seem to be a pretty obvious one.

Thanks,

	tglx


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/