linux-kernel - Re: MMC: logical-bitwise and confusion in tifm_sd_transfer

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080310135630.5184b87b@mjolnir.drzeus.cx>
Date:	Mon, 10 Mar 2008 13:56:30 +0100
From:	Pierre Ossman <drzeus-mmc@...eus.cx>
To:	Roel Kluin <12o3l@...cali.nl>, Alex Dubov <oakad@...oo.com>
Cc:	lkml <linux-kernel@...r.kernel.org>
Subject: Re: MMC: logical-bitwise and confusion in  tifm_sd_transfer_data()?

On Sun, 09 Mar 2008 21:31:08 +0100
Roel Kluin <12o3l@...cali.nl> wrote:

> from drivers/mmc/host/tifm_sd.c:183:
> 
> if ((r_data->flags & MMC_DATA_WRITE)
>     && DATA_CARRY)
> 
> shouldn't this be bit-wise &?

First off, I'm not the maintainer of that driver, Alex Dubov is.

Second, the code seems broken, but not in the way you suggest. It should probably have been:

if ((r_data->flags & MMC_DATA_WRITE)
	&& (host->cmd_flags & DATA_CARRY))

Alex, could you have a look?

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/