linux-kernel - RE: [Linux-fbdev-devel] [PATCH 1/1 try#2] [VIDEO/FRAMEBUFFER]: add BF52x EZkit Display driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <600D5CB4DFD93545BF61FF01473D11AC12E9A755@limkexm2.ad.analog.com>
Date:	Mon, 10 Mar 2008 14:35:45 -0000
From:	"Hennerich, Michael" <Michael.Hennerich@...log.com>
To:	<geert@...ux-m68k.org>, <linux-fbdev-devel@...ts.sourceforge.net>,
	"Bryan Wu" <bryan.wu@...log.com>
Cc:	"Andrew Morton" <akpm@...ux-foundation.org>,
	"Randy Dunlap" <randy.dunlap@...cle.com>, <adaplas@...il.com>,
	"Michael Hennerich" <michael.hennerich@...log.com>,
	<linux-kernel@...r.kernel.org>
Subject: RE: [Linux-fbdev-devel] [PATCH 1/1 try#2] [VIDEO/FRAMEBUFFER]: add BF52x EZkit Display driver



>From: geert@...ux-m68k.org [mailto:geert@...ux-m68k.org]
>Subject: Re: [Linux-fbdev-devel] [PATCH 1/1 try#2] [VIDEO/FRAMEBUFFER]:
add
>BF52x EZkit Display driver
>
>On Thu, 6 Mar 2008, Bryan Wu wrote:
>> On Wed, Mar 5, 2008 at 11:02 PM, Andrew Morton
>> <akpm@...ux-foundation.org> wrote:
>> > On Thu, 31 Jan 2008 00:49:43 +0800 Bryan Wu <bryan.wu@...log.com>
>wrote:
>> >  > +     fbinfo =
>> >  > +         framebuffer_alloc(sizeof(struct bfin_t350mcqbfb_info),
>&pdev->dev);
>> >  > +     if (!fbinfo) {
>> >  > +             ret = -ENOMEM;
>> >  > +             goto out2;
>> >  > +     }
>
>    [...]
>
>> >  > +     fbinfo->pseudo_palette = kmalloc(sizeof(u32) * 16,
>GFP_KERNEL);
>> >  > +     if (!fbinfo->pseudo_palette) {
>> >  > +             printk(KERN_ERR DRIVER_NAME
>> >  > +                    "Fail to allocate pseudo_palette\n");
>> >  > +
>> >  > +             ret = -ENOMEM;
>> >  > +             goto out4;
>> >  > +     }
>> >  > +
>> >  > +     memset(fbinfo->pseudo_palette, 0, sizeof(u32) * 16);
>> >
>> >  You just invented kzalloc!
>> >
>>
>> Right
>
>Alternatively, you could embed the pseudo palette inside struct
>bfin_t350mcqbfb_info, so it's allocated by the framebuffer_alloc() call
>above.

This makes the most sense.
Bryan is going to send an updated patch, including your and Andrew's
recommendations.

Thanks and best regards,
Michael
 

>
>Gr{oetje,eeting}s,
>
>						Geert
>
>--
>Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@...ux-
>m68k.org
>
>In personal conversations with technical people, I call myself a
hacker.
>But
>when I'm talking to journalists I just say "programmer" or something
like
>that.
>							    -- Linus
Torvalds
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/