linux-kernel - Re: ADT746X: logical-bitwise & confusion in set_max_duty_at

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20080310181319.GA7500@tree.beaverton.ibm.com>
Date:	Mon, 10 Mar 2008 11:13:19 -0700
From:	"Darrick J. Wong" <djwong@...ibm.com>
To:	Roel Kluin <12o3l@...cali.nl>
Cc:	Segher Boessenkool <segher@...nel.crashing.org>,
	benh@...nel.crashing.org, linuxppc-dev@...abs.org,
	lkml <linux-kernel@...r.kernel.org>,
	Colin Leroy <colin@...ino.net>
Subject: Re: ADT746X: logical-bitwise & confusion in set_max_duty_at_crit()

On Mon, Mar 10, 2008 at 10:59:43AM +0100, Roel Kluin wrote:

> > The & 0xff here is bogus anyway; temp is only ever used as an u8,
> > so just declare it as that, or do proper overflow/underflow checking
> > on it.  The patch will need testing on hardware too, since it changes
> > behaviour (it should be a bugfix, but who knows).
> 
> Maybe someone can test this?

I did.  No regressions observed and it fixes that bug as well.  Sorry I
didn't catch it earlier... :/

Acked-by: Darrick J. Wong <djwong@...ibm.com>

--D
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/