linux-kernel - Re: [PATCH] firewire: debug AT, AR, and selfID-complete events

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <200803100047.05387.jwilson@redhat.com>
Date:	Mon, 10 Mar 2008 00:47:05 -0400
From:	Jarod Wilson <jwilson@...hat.com>
To:	linux1394-devel@...ts.sourceforge.net
Cc:	Stefan Richter <stefanr@...6.in-berlin.de>,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firewire: debug AT, AR, and selfID-complete events

On Sunday 09 March 2008 04:49:34 pm Stefan Richter wrote:
> This adds debug printks for asynchronous transmission and reception and
> for self ID reception.  The debug code is per default deactivated by #if
> blocks.
>
> Signed-off-by: Stefan Richter <stefanr@...6.in-berlin.de>
> ---
>
> I am undecided whether this is OK for mainline, and whether the debug
> options should become a Kconfig option or runtime options.
>
> It may be temporarily useful to the few driver developers.  Do we want
> end users to provide us with debug logs of this kind?  Then it should
> be one or two runtime options.


My vote would be to include this sort of thing with a run-time option to 
enable the extra spew, since its a perfectly accepted standard for other 
drivers. It ought to be extremely useful in determining whats going wrong 
with end-user setups, particularly in cases where we can't reproduce the 
problem (typically for lack of having the specific hardware in-house).


-- 
Jarod Wilson
jwilson@...hat.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@...r.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/